1. Variable abbreviations - op is short for object pointer, ob is for object, and pl is for player.
2. Some functions are named using the conventions above - the naming effects what options they take (insert_ob_in_ob takes 2 object structures)
3. Use descriptive variable names.
   • op and pl should only be used for temporary variables (cycling through the list or the like).
   • For variables well defined, use an accurate name (ie, hitter, sack, etc).
4. Local variable names. Just a rules of thumb. These are ok:

   int mylongvarname;
   int my_long_var_name;

   • Do NOT use caps except for typedefs, enums and defines.

1. Some structure elements should never be accessed directly - rather, there are other functions to use the values.
   • object→owner: This contains the owner id for this object. Use set_owner and get_owner instead. Directly using object→owner is likely to get unpredictable results.
   • object→nrof: This contains the number of an object. Since changing this will change the weight of an object, direct access should also be avoided. Use decrease_ob_nr, split_ob, and insert_ob_in_… - the later will merge the objects if applicable.
2. If using insert_ob_in_map and plan to do further actions with the object, check and make sure the object still exists after insertion - it is possible that the object gets destroyed while being inserted (eaten by an altar or such).

1. Files are created with standard content blocks.

   char *rcsid_component_file_ext =
       "$Id: file.ext$";
   /*
    * Project name, brief description
    *
    * Copyright information
    *
    * GPL blurb here
    *
    * Contact information
    */
   
   /**
    * @file path/to/file.ext
    * A brief description.  Detailed information may follow.
    */

   • The rcsid_ variable is useful for creating error and debug messages. For component, look at other files nearby.
   • The @file path is important when multiple files in the project may have the same name in different directories.
   • Do not include trunk or branches/1.x in the @file comment header path.
   • The @file comment block helps doxygen create meaningful output.
   • The license block requirement is obvious.

1. Only add name options with #ifdef's to the config file if the behaviour seriously changes the game. Adding a new spell does not warrant an #ifdef. There are already too many options in the config.h file.
2. If you want to add special debug code for certain compiles, generate a unique #define for it - don't use the global DEBUG. For example, NEWCS_DEBUG.

1. Try to keep lines to less than 80 columns when possible. This is not a strict requirement - don't break up some complex comparison because the line would otherwise be 83 characters long. Xterms can be resized to most any width. However, use your judgment on whether breaking up a long line would make something more or less readable.
2. Write code that can easily be maintained in the future, not code that is easiest to write quickly. In other words, do not do the quick and dirty hack, but instead always write code with maintainability and clarity in mind.

1. Indentation is 4 spaces. This can be a pain to read, but most functions should be consistent through the function.
   • While a lot of old code may use 2 spaces, a move to 4 spaces makes readability easier.
2. #if directives and friends are not indented.

1. Try to use the [s/u]int[8/16/32] whenever possible. Use the one of appropriate size/type. If not sure, go for the next size up. Do not ever write code assuming that any of those will have an exact number of bits - those types only mean that you will get at least that many bits - you may get more.
   • The exception to this are strings. Continue to use char, since the signed-ness of functions that take string options can differ system to system, and generate excessive warnings if the wrong sign is used.

1. As discussed on irc, the preferred style for expressions is like this:

   if (expression) {
     statement;
     statement;
   }

   if <space> (expression), the space between the if and expression is required.
   NOT like this:

   if(expression)
   {
     statement;
     statement;
   }

   • Also applies to for (), switch (), and while ().
2. The preferred style of formal parameters:

   void myFooFunction(param1, param2, param3) {
     statement;
     statement;
   }

   • No space after the left parenthesis
   • No space before the right parenthesis
   • Comma right after the formal parameters
   • Space after the commas.

1. When adding new function, include a comment of what the function is supposed to do, what options it takes, and what if any value it returns. This makes debugging of such functions easier, and also makes it better known to other developers if that function might be useful to them.
2. Do not use C++ style comments (//).
3. Functions are documented like this.

   /**
    * A brief descriptive sentence summarizes the function.  An overview ends
    * at the first period and space, then the detailed information follows.
    *
    * @param bla
    * This is a parameter
    * @return
    * returns NULL
    */

   • This lets doxygen generate nice documentation.
4. Use the following block commenting style.

   /*
    * Do block comments like this.
    * Get in the habit of using a
    * brief and detailed style.
    */
   
   /*
     and not
     like this
    */
   
   /* but single line comment using this method is fine */

   • It is much easier to spot the block comments if they all start with *, and they tend to be worth noticing.
5. To document variables in doxygen, format the comment as shown below:
   • Simple

     int a_var_name; /**< Raison d'etre.. */

   • Multi-line

     int my_var_name; /**< A very long
                       *   Raison d'etre.. */

   • Large group summary, with individuals commented also.

     /**@{
      * @name UI Widgets
      * Widgets for the keybinding dialog
      */
     static GtkWidget *fire_label, *run_label, *keybinding_window,
         *keybinding_button_bind;
     static GtkListStore *keybinding_store;  /**<Bound key list for bind dialog.*/
     static GtkTreeSelection *keybinding_selection;
     /* @} EndOf UI Widgets */

This is a cross-platform project. Do not assume everyone else has the same system you have:

1. Do not use non-standard gcc extensions
   • // for comment lines
   • Nested functions
   • Declaration of arrays with variable bounds
   • Etc.
2. Do not use special system functions
   • Do not assume the target is a BSD, SVR4 system, etc.
   • If a potentially non-standard function must be used:
     • Add checks in the autoconf script.
     • Include a version of the function in case it is not on that system.
3. Assume all names use one name space. For example, if there is a struct called spell, don't make the name of an optional parameter spell. This will break on ANSI C compilers that follow the spec strictly (gcc does not, even with -strict -ansi)

1. Log errors/diagnostics with the LOG function. When doing so, please include the function name - this is especially true for errors.

1. Send patches on a bug fix or feature enhancement basis individually, and do not make mega-patches. A diff that changes 10 things is more difficult for developers to review and understand as unrelated changes might be going on. It is also harder to reject part of a patch (feature X is nice, but Y doesn't work).
2. Please state in the message included with the patch what it fixes/changes. Too often, patches are just a bunch of source code, with no indication why it should be incorporated. Without such commentary, it may be difficult to even determine if the bug it fixes is still there in the source it patches. Please also state what version of crossfire the diff is for.
3. When posting a patch on the patch tracker at SourceForge, please explicitly state whether or not you want that patch incorporated into the master source. Many times, a patch may be made available on an experimental basis which is not ready for widespread distribution.
4. When making patches, please make context diffs. Please also include the directory that the file is in (run the diff in the top level directory). Please make 5 line context diffs - larger line context diffs are fine if you think that may make it easier.
   Example:

   diff -c5 (oldfile) (newfile)

   You can also do diffs of entire directories. To do this, type:

   diff -c5 -r (old_directory) (new_directory)

   An example:

   diff -c5 -r crossfire-0.90.1 crossfire-0.90.2

5. Gnu diff will include files that did not exist before. Other diff programs may not do this.
6. If your diff looks excessively long and you made a lot of formatting changes, you can add -w to the diff options to have it ignore whitespace. Note that this will then mean that those formatting changes will then be lost.
7. There is no need to make a separate diff file for each file that is different (ie, treasure.diff, player.diff, etc). Assuming you follow steps 1-6, all the diffs can be contained in one file, and patch will deal with it just fine.
8. If you need to send a map, new archetypes, or other new files where a diff doesn't make sense, a uuencoded tar file will suffice.

Submit all patches to the Sourceforge patch tracker on http://sourceforge.net/tracker/?group_id=13833&atid=313833, and mail an announcement to crossfire@metalforge.org.